Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify public code #180

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented May 18, 2020

  • Mark an unused function as dead code
  • identify rust-code-analysis public API

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman May 18, 2020 09:48
@codecov-io
Copy link

Codecov Report

Merging #180 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   15.84%   15.90%   +0.06%     
==========================================
  Files          44       43       -1     
  Lines        5448     5438      -10     
  Branches      597      595       -2     
==========================================
+ Hits          863      865       +2     
+ Misses       4304     4291      -13     
- Partials      281      282       +1     
Impacted Files Coverage Δ
src/metrics/loc.rs 46.28% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bac694...095ef13. Read the comment docs.

@Luni-4 Luni-4 force-pushed the identify-public-code branch from 095ef13 to 354e8ce Compare May 19, 2020 11:39
@Luni-4 Luni-4 requested a review from calixteman May 19, 2020 11:39
@codecov-commenter
Copy link

Codecov Report

Merging #180 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   15.84%   15.87%   +0.03%     
==========================================
  Files          44       44              
  Lines        5448     5448              
  Branches      597      597              
==========================================
+ Hits          863      865       +2     
+ Misses       4304     4301       -3     
- Partials      281      282       +1     
Impacted Files Coverage Δ
src/asttools.rs 0.00% <ø> (ø)
src/metrics/loc.rs 46.28% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bac694...354e8ce. Read the comment docs.

@Luni-4 Luni-4 mentioned this pull request May 28, 2020
@calixteman calixteman merged commit 2bb3299 into mozilla:master Jun 1, 2020
@Luni-4 Luni-4 deleted the identify-public-code branch June 1, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants